Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power (^) function gives NaN at 0 #57

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix power (^) function gives NaN at 0 #57

merged 2 commits into from
Sep 27, 2023

Conversation

tansongchen
Copy link
Member

@tansongchen tansongchen commented Sep 27, 2023

This solves #54 #41 and #33 by eliminating division altogether

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6b0b0e9) 85.48% compared to head (748d7db) 84.46%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   85.48%   84.46%   -1.03%     
==========================================
  Files           6        6              
  Lines         248      251       +3     
==========================================
  Hits          212      212              
- Misses         36       39       +3     
Files Coverage Δ
src/codegen.jl 100.00% <100.00%> (ø)
src/primitive.jl 85.71% <85.71%> (-2.71%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tansongchen tansongchen merged commit 32a41f1 into main Sep 27, 2023
5 of 6 checks passed
@tansongchen tansongchen deleted the power branch September 27, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant